feat(SyntheticTimeSeries): add optional timezone argument to the query method#2465
feat(SyntheticTimeSeries): add optional timezone argument to the query method#2465
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2465 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 191 191
Lines 26152 26156 +4
=======================================
+ Hits 12778 12781 +3
- Misses 13374 13375 +1
🚀 New features to boost your workflow:
|
haakonvt
left a comment
haakonvt
left a comment
There was a problem hiding this comment.
In the existing datapoints methods I see we allow more than just str | None: str | datetime.timezone | ZoneInfo | None. There is existing utility to handle this so I guess you should do the same here. You can look up convert_timezone_to_str
haakonvt
left a comment
haakonvt
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing!
andreolefirenko
added
the
waiting-for-risk-review
haakonvt
added
waiting-for-team
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 participants
Description
This PR introduces an optional timezone argument to the SyntheticDatapointsAPI.query method, aligning it with the API specification.
https://api-docs.cognite.com/20230101/tag/Synthetic-Time-Series/operation/querySyntheticTimeseries
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.